Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump the flake and fix the zfs disk #848

Merged
merged 2 commits into from
Oct 21, 2024
Merged

bump the flake and fix the zfs disk #848

merged 2 commits into from
Oct 21, 2024
+59 −87

Conversation

brianmcgillion
Copy link
Collaborator

@brianmcgillion brianmcgillion commented Oct 16, 2024 •
edited
Loading

Description of changes

Remove unneeded partitions
Add compression
Add swap space

  • enable resume from the swap partition

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
    the flake update should be tested on all targets
    the zfs changes should be tested on the x1 image
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?
    It enables swap partition and removes some unused partitions

A full installation is needed to verify the changes and to ensure that the changes have been applied. without a full installation the image will not boot on the x1

@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow October 16, 2024 05:21 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion marked this pull request as draft October 16, 2024 05:21
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow October 16, 2024 06:39 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow October 16, 2024 07:15 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow October 16, 2024 12:35 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow October 16, 2024 12:37 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow October 18, 2024 09:01 — with GitHub Actions Inactive
@brianmcgillion
Bump the flake lock to the latest
9f2ebf9 
Signed-off-by: Brian McGillion <[email protected]>
@brianmcgillion
Fix the zfs partitions
0326283 
Remove unneeded partitions
Add compression
Add swap space
- enable encrypted swap
- enable resume from the swap partition

Signed-off-by: Brian McGillion <[email protected]>
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow October 21, 2024 03:09 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion marked this pull request as ready for review October 21, 2024 04:04
@leivos-unikie leivos-unikie added the Tested on RISC-V This PR has been tested on RISC-V - Microchip Polarfire Icicle-kit board label Oct 21, 2024
@leivos-unikie
Copy link
Contributor

Tested on riscv icicle-kit. Didn't find any issues.

@johannarautanen
Copy link

johannarautanen commented Oct 21, 2024 •
edited
Loading

Tested with native Orin-AGX.

-no new fndings.
-all ghaf apps can be launched
-ci-test automation cases ok (older auitomation tests before 18th oct):
there are issue with automatic AGX netvm-cases, but manually tested ie the netvm restart worked ok.

Tested with native Orin-NX
-no new findings
-all ghaf apps can be launched
-ci-test automation cases ok(older auitomation tests before 18th oct)

@johannarautanen johannarautanen added Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin Tested on Orin NX This PR has been tested on NVIDIA Jetson NX Orin labels Oct 21, 2024
@milva-unikie
Copy link

Tested on Lenovo-X1 (new installation with debug-installer)

Working:

  • Swap memory works in host.
  • Installation works. It took a bit longer than before, about 2,5 minutes. Still not bad.
  • Checked also quickly the debug-image, seems to be fine.
  • Test-automation passes.

Issues:

This pr bumps ghafpkgs and brings in new changes to Audio Control that have not been tested yet. I noticed a few issues with it:

  • Depending on the connections the user can be shown a long list of devices with no indication what is active. At the moment only one speaker and one microphone can be active. The user can not change which one it is (the priority order goes something like Bluetooth -> 3,5mm/USB -> internal).
  • System volume in taskbar is tied to the Audio Control level of the active speaker. Again, no indication about this shown to the user. If the user mutes the active speaker in Audio Control and after that changes the system volume from task bar, the muted speaker gets unmuted.
  • Minor: All arrows are pointing in wrong direction at startup.

I can create separate bugs about these.

@milva-unikie milva-unikie added the Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon label Oct 21, 2024
@brianmcgillion brianmcgillion merged commit 7330d67 into tiiuae:main Oct 21, 2024
12 of 14 checks passed
@brianmcgillion brianmcgillion deleted the bump-and-zfs branch October 21, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humaidq-tii humaidq-tii humaidq-tii approved these changes

@milva-unikie milva-unikie Awaiting requested review from milva-unikie

Assignees
No one assigned
Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin Tested on Orin NX This PR has been tested on NVIDIA Jetson NX Orin Tested on RISC-V This PR has been tested on RISC-V - Microchip Polarfire Icicle-kit board
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brianmcgillion @leivos-unikie @johannarautanen @milva-unikie @humaidq-tii